https://bugzilla.redhat.com/show_bug.cgi?id=2344240 --- Comment #16 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Thanks for the update - there's a few minor issues left, but nothing major I can see. 1. There's a new version out (0.3.6), it would be great to get that in, but I'll leave it up to you whether you want to update before going through the review or afterwards. 2. It looks like the Source URL for the COPYING.LIB file can't be parsed by RPM (or by spectool) - the "?ref_type=heads" URL parameter seems to throw it off. You can verify that by putting the .spec file through "spectool --list-files" or "spectool --get-files". It downloads a file called "heads". I think just dropping the "?ref_type=heads" parameter from the URL should fix that. 3. The way you list the license texts under %files causes duplicates to be included: > %license LICENSE.txt LGPL-2.1 This causes both files to get copied to /usr/share/licenses/%{name}/ *and* to be included from ".". Using this instead causes only one copy to be included and to be marked as a %license file in RPM metadata: %license %{crate_instdir}/LICENSE.txt %license %{crate_instdir}/LGPL-2.1 Using a matching filename for the latter might be good to -- something like "LICENSE-LGPL-2.1.txt" maybe? Or just keep it as "COPYING.LIB"? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2344240 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202344240%23c16 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
