https://bugzilla.redhat.com/show_bug.cgi?id=2325933 --- Comment #23 from Jakub Jelen <jjelen@xxxxxxxxxx> --- (In reply to Fabio Valentini from comment #22) > Apparently yes :D > > You can drop these four lines: > > > # prevent library files from being installed > > %global cargo_install_lib 0 > > %cargo_install -f dynamic,nssdb,standard > > rm -f $RPM_BUILD_ROOT/%{_bindir}/conformance > > If you don't call %cargo_install, the rest is unnecessary. > You're already installing the .so file manually, so %cargo_install does > *only* things you need to manually prevent or un-do. > So ... just don't call %cargo_install xD What about the `%{_bindir}/softhsm_migrate`? It is still needed to be installed. > You also added a new issue into the License tag. > > The "GPL-3.0" identifier is not a valid SPDX identifier in Fedora. It is > deprecated in SPDX upstream, and should be either "GPL-3.0-or-later" or > "GPL-3.0-only". Given that the SourceLicense is GPL-3.0-or-later, I assume > it should be the former. Thanks for double-checking. Fixed. > I don't know where you copied the deprecated identifier from, because > whereever it came from, it should have matched where GPL-3.0-or-later for > SourceLicense came from. So there appears to be either an inconsistency or a > copy-paste-error happened. Let me try to backtrace the issue. I think I took it from the output of `%cargo_license_summary`. Running `mockbuild results in the following output, which I used to update the licence from: ``` + /usr/bin/env CARGO_HOME=.cargo RUSTC_BOOTSTRAP=1 'RUSTFLAGS=-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Cforce-frame-pointers=yes -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes --cap-lints=warn' /usr/bin/cargo tree -Z avoid-dev-deps --workspace --offline --edges no-build,no-dev,no-proc-macro --no-dedupe --target all --features dynamic,nssdb,standard --prefix none --format '# {l}' + sed -e 's: / :/:g' -e 's:/: OR :g' + sort -u # Apache-2.0 # Apache-2.0 OR BSL-1.0 # Apache-2.0 OR MIT # BSD-2-Clause OR Apache-2.0 OR MIT # BSD-3-Clause # GPL-3.0 # MIT # MIT OR Apache-2.0 # MIT-0 OR Apache-2.0 # Unlicense OR MIT ``` -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2325933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325933%23c23 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
