https://bugzilla.redhat.com/show_bug.cgi?id=2325933 --- Comment #22 from Fabio Valentini <decathorpe@xxxxxxxxx> --- Apparently yes :D You can drop these four lines: > # prevent library files from being installed > %global cargo_install_lib 0 > %cargo_install -f dynamic,nssdb,standard > rm -f $RPM_BUILD_ROOT/%{_bindir}/conformance If you don't call %cargo_install, the rest is unnecessary. You're already installing the .so file manually, so %cargo_install does *only* things you need to manually prevent or un-do. So ... just don't call %cargo_install xD You also added a new issue into the License tag. The "GPL-3.0" identifier is not a valid SPDX identifier in Fedora. It is deprecated in SPDX upstream, and should be either "GPL-3.0-or-later" or "GPL-3.0-only". Given that the SourceLicense is GPL-3.0-or-later, I assume it should be the former. I don't know where you copied the deprecated identifier from, because whereever it came from, it should have matched where GPL-3.0-or-later for SourceLicense came from. So there appears to be either an inconsistency or a copy-paste-error happened. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2325933 Report this comment as SPAM: https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=report-spam&short_desc=Report%20of%20Bug%202325933%23c22 -- _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
