On 6/30/25 3:19 PM, Mikulas Patocka wrote:
>> On Wed, 25 Jun 2025, Xose Vazquez Perez wrote:
>> [...]>> diff --git a/drivers/md/dm-ps-service-time.c b/drivers/md/dm-ps-service-time.c
index 969d31c40272..cbb0ac63bb7a 100644
--- a/drivers/md/dm-ps-service-time.c
+++ b/drivers/md/dm-ps-service-time.c
@@ -20,7 +20,6 @@
#define ST_MAX_RELATIVE_THROUGHPUT 100
#define ST_MAX_RELATIVE_THROUGHPUT_SHIFT 7
#define ST_MAX_INFLIGHT_SIZE ((size_t)-1 >> ST_MAX_RELATIVE_THROUGHPUT_SHIFT)
-#define ST_VERSION "0.3.0"
struct selector {
struct list_head valid_paths;
@@ -344,7 +343,7 @@ static int __init dm_st_init(void)
if (r < 0)
DMERR("register failed %d", r);
- DMINFO("version " ST_VERSION " loaded");
+ DMINFO(" loaded");
return r;
}
--
2.50.0
I think this isn't needed. The version doesn't do any harm.
Wrong information is provided to the user.
The code is modified, but the version remains the same.
Usually MODULE_VERSION has the same problem in the kernel tree.
