Hi
I think this isn't needed. The version doesn't do any harm.
Mikulas
On Wed, 25 Jun 2025, Xose Vazquez Perez wrote:
> Reminiscent of ancient times, when modules were developed outside the kernel.
> Pretty useless nowadays for code included in the official kernel repo, with constant
> changes and without updating the version number.
>
> Cc: Alasdair Kergon <agk@xxxxxxxxxx> (maintainer:DEVICE-MAPPER (LVM))
> Cc: Mike Snitzer <snitzer@xxxxxxxxxx> (maintainer:DEVICE-MAPPER (LVM))
> Cc: Mikulas Patocka <mpatocka@xxxxxxxxxx> (maintainer:DEVICE-MAPPER (LVM))
> Cc: DM-DEVEL ML <dm-devel@xxxxxxxxxxxxxxx> (open list:DEVICE-MAPPER (LVM))
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@xxxxxxxxx>
> ---
> BTW, MODULE_VERSION should be removed from the entire tree.
> ___
> drivers/md/dm-ps-historical-service-time.c | 3 +--
> drivers/md/dm-ps-queue-length.c | 3 +--
> drivers/md/dm-ps-round-robin.c | 3 +--
> drivers/md/dm-ps-service-time.c | 3 +--
> 4 files changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/md/dm-ps-historical-service-time.c b/drivers/md/dm-ps-historical-service-time.c
> index b49e10d76d03..fa6198c0276b 100644
> --- a/drivers/md/dm-ps-historical-service-time.c
> +++ b/drivers/md/dm-ps-historical-service-time.c
> @@ -31,7 +31,6 @@
>
> #define DM_MSG_PREFIX "multipath historical-service-time"
> #define HST_MIN_IO 1
> -#define HST_VERSION "0.1.1"
>
> #define HST_FIXED_SHIFT 10 /* 10 bits of decimal precision */
> #define HST_FIXED_MAX (ULLONG_MAX >> HST_FIXED_SHIFT)
> @@ -544,7 +543,7 @@ static int __init dm_hst_init(void)
> if (r < 0)
> DMERR("register failed %d", r);
>
> - DMINFO("version " HST_VERSION " loaded");
> + DMINFO(" loaded");
>
> return r;
> }
> diff --git a/drivers/md/dm-ps-queue-length.c b/drivers/md/dm-ps-queue-length.c
> index e305f05ad1e5..31decbef9837 100644
> --- a/drivers/md/dm-ps-queue-length.c
> +++ b/drivers/md/dm-ps-queue-length.c
> @@ -25,7 +25,6 @@
>
> #define DM_MSG_PREFIX "multipath queue-length"
> #define QL_MIN_IO 1
> -#define QL_VERSION "0.2.0"
>
> struct selector {
> struct list_head valid_paths;
> @@ -263,7 +262,7 @@ static int __init dm_ql_init(void)
> if (r < 0)
> DMERR("register failed %d", r);
>
> - DMINFO("version " QL_VERSION " loaded");
> + DMINFO(" loaded");
>
> return r;
> }
> diff --git a/drivers/md/dm-ps-round-robin.c b/drivers/md/dm-ps-round-robin.c
> index d1745b123dc1..67f7f5ec5428 100644
> --- a/drivers/md/dm-ps-round-robin.c
> +++ b/drivers/md/dm-ps-round-robin.c
> @@ -19,7 +19,6 @@
>
> #define DM_MSG_PREFIX "multipath round-robin"
> #define RR_MIN_IO 1
> -#define RR_VERSION "1.2.0"
>
> /*
> *---------------------------------------------------------------
> @@ -223,7 +222,7 @@ static int __init dm_rr_init(void)
> if (r < 0)
> DMERR("register failed %d", r);
>
> - DMINFO("version " RR_VERSION " loaded");
> + DMINFO(" loaded");
>
> return r;
> }
> diff --git a/drivers/md/dm-ps-service-time.c b/drivers/md/dm-ps-service-time.c
> index 969d31c40272..cbb0ac63bb7a 100644
> --- a/drivers/md/dm-ps-service-time.c
> +++ b/drivers/md/dm-ps-service-time.c
> @@ -20,7 +20,6 @@
> #define ST_MAX_RELATIVE_THROUGHPUT 100
> #define ST_MAX_RELATIVE_THROUGHPUT_SHIFT 7
> #define ST_MAX_INFLIGHT_SIZE ((size_t)-1 >> ST_MAX_RELATIVE_THROUGHPUT_SHIFT)
> -#define ST_VERSION "0.3.0"
>
> struct selector {
> struct list_head valid_paths;
> @@ -344,7 +343,7 @@ static int __init dm_st_init(void)
> if (r < 0)
> DMERR("register failed %d", r);
>
> - DMINFO("version " ST_VERSION " loaded");
> + DMINFO(" loaded");
>
> return r;
> }
> --
> 2.50.0
>
