On Wed, 2025-09-10 at 16:21 +0530, Kotresh Hiremath Ravishankar wrote: > Sorry, couldn't get to this after my PTO. Comments inline. > <skipped> > > > > > > + pr_warn_client(cl, "fsname doesn't match\n"); > > > > What's about sharing the mismatched names? > > > > pr_warn_client(cl, "fsname %s doesn't match to mds_namespace %s\n"); > > > I was doubtful initially that this code can get executed before the > mds_namespace is initialized and > also if fsname can be null. I think this can be done as pr_warn_client > handles NULL gracefully? > Yes, we need to manage access to the pointers properly. But if we have valid pointers on fsname and mds_namespace, then it could be good to show the name(s). It will make the error message more informative. And if we have NULL pointers, then sharing something like <empty> will be also informative enough. Otherwise, it will need to debug the code to understand which code flow we have for the particular situation. Thanks, Slava. >
