On Wed, Jul 9, 2025 at 2:08 PM Blake Jones <blakejones@xxxxxxxxxx> wrote: > > On Wed, Jul 9, 2025 at 2:02 PM Ian Rogers <irogers@xxxxxxxxxx> wrote: > > > +++ b/tools/perf/tests/shell/test_bpf_metadata.sh > > > @@ -0,0 +1,76 @@ > > > +#!/bin/sh > > > +# SPDX-License-Identifier: GPL-2.0 > > > > The 2nd line in a shell test script is taken to be the name of the test, so > > ``` > > $ perf test list 108 > > 108: SPDX-License-Identifier: GPL-2.0 > > ``` > > > > > +# > > > +# BPF metadata collection test. > > > > This should be on line 2 instead. > > Oof, that sure wasn't on my radar. Should I do a followup patch, or is > it not worth bothering? The patch has been in perf-tools-next for a few weeks: https://web.git.kernel.org/pub/scm/linux/kernel/git/perf/perf-tools-next.git/commit/?h=perf-tools-next&id=edf2cadf01e8f2620af25b337d15ebc584911b46 so modifying it is probably not a good idea (it'd need a forced push and break people downstream). If you could send a follow up, that'd be great just so that we have >1 person in the author/reviewer/signed-off-by tag! Thanks, Ian
