On Wed, Jul 9, 2025 at 2:02 PM Ian Rogers <irogers@xxxxxxxxxx> wrote: > > +++ b/tools/perf/tests/shell/test_bpf_metadata.sh > > @@ -0,0 +1,76 @@ > > +#!/bin/sh > > +# SPDX-License-Identifier: GPL-2.0 > > The 2nd line in a shell test script is taken to be the name of the test, so > ``` > $ perf test list 108 > 108: SPDX-License-Identifier: GPL-2.0 > ``` > > > +# > > +# BPF metadata collection test. > > This should be on line 2 instead. Oof, that sure wasn't on my radar. Should I do a followup patch, or is it not worth bothering?