Re: [PATCH v3 bpf 0/2] bpf: Fix softlock condition in BPF hashmap interation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/24/2025 11:32 PM, Brandon Kammerdiener wrote:
> Hi,
>
> This patchset fixes an endless loop condition that can occur in
> bpf_for_each_hash_elem, causing the core to softlock. My understanding is
> that a combination of RCU list deletion and insertion introduces the new
> element after the iteration cursor and that there is a chance that an RCU
> reader may in fact use this new element in iteration. The patch uses a
> _safe variant of the macro which gets the next element to iterate before
> executing the loop body for the current element.
>
> I have also added a subtest in the for_each selftest that can trigger this
> condition without the fix.
>
> Changes since v2:
> - Renaming and additional checks in selftests/bpf/prog_tests/for_each.c
>
> Changes since v1:
> - Added missing Signed-off-by lines to both patches
>
> Thanks,
> Brandon Kammerdiener

Acked-by: Hou Tao <houtao1@xxxxxxxxxx>





[Index of Archives]     [Linux Samsung SoC]     [Linux Rockchip SoC]     [Linux Actions SoC]     [Linux for Synopsys ARC Processors]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]


  Powered by Linux