RE: [EXTERNAL] Re: [PATCH v4 2/6] ASoC: ops: add snd_soc_get_volsw_clamped

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]



> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Thursday, September 11, 2025 9:34 PM
> To: Holalu Yogendra, Niranjan <niranjan.hy@xxxxxx>
> Subject: Re: [PATCH v4 2/6] ASoC: ops: add
> snd_soc_get_volsw_clamped
> 
> On Thu, Sep 11, 2025 at 09:26:59PM +0530, Niranjan H Y wrote:
> >   Add API snd_soc_get_volsw_clamped to read
> >   the volume from device. This similar to
> >   existing API snd_soc_get_volsw. But has
> >   additional step to clamp the value to max value
> >   if the register value is larger than max value.
> 
> Why is this a separate API, what is the situation where we would want to
> report an invalid value from a control?  I was thinking of just adding
> this to the existing operations rather than adding separate ones that
> need to be explicitly set.
  Since few of the drivers as still using the original API, and was not sure if
everyone wanted to clamp the register value, did not want to disturb the
original API snd_soc_get_volsw. Per my analysis, if register read fails due to 
some issue (like IO) and, for some reason if register value was modified
to have the value greater than mc->max value, the volume is report erroneously.
  Are you thinking that this patch could be dropped and clamp the value to max in  
'soc_get_volsw' (as in 1st patch) and use the same API ? Please suggest.

Thanks,
Niranjan H Y







[Index of Archives]     [Pulseaudio]     [Linux Audio Users]     [ALSA Devel]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]

  Powered by Linux