Re: [PATCH 1/2] api: remote: introduce virDomainBlockRebase2 API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 29, 2025 at 10:55:29AM +0300, Nikolai Barybin via Devel wrote:
> This new API is a combination of virDomainBlockPull and
> virDomainBlockRebase (without copy mode) which supports extendable
> list of virTypedParameterPtr params.
> 
> It is designed to allow more configurable use of underlying
> 'block-stream' QMP command.
> 
> If "base" == NULL and flags == 0 it is equivalent to virDomainBlockPull.
> 
> Signed-off-by: Nikolai Barybin <nikolai.barybin@xxxxxxxxxxxxx>
> ---
>  include/libvirt/libvirt-domain.h | 43 +++++++++++++++++++++
>  src/driver-hypervisor.h          |  8 ++++
>  src/libvirt-domain.c             | 65 ++++++++++++++++++++++++++++++++
>  src/libvirt_public.syms          |  5 +++
>  src/remote/remote_driver.c       |  1 +
>  src/remote/remote_protocol.x     | 17 ++++++++-
>  src/remote_protocol-structs      | 10 +++++
>  7 files changed, 148 insertions(+), 1 deletion(-)

> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index ca110bdf85..58e3746a09 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -11197,6 +11197,71 @@ virDomainBlockRebase(virDomainPtr dom, const char *disk,
>  }
>  
>  
> +/**
> + * virDomainBlockRebase2:

Our normal convention would be to call this virDomainBlockRebaseParams


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|




[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux