> So while I agree that it needs to work properly with the reservation > code, with the way the code is structured I don't think we should hide > something which reserves ports into code that is not expected to do > that. Yeah, I see what you're saying. Given this, there are some options available to us. 1. We could move that conditional out into virDomainVirtioSerialAddrAssign, that might require a similar query for the controller, to ultimately get the map. 2. We could possibly modify virDomainVirtioSerialAddrReserve, and/or virDomainVirtioSerialAddrIsComplete Im open to any other suggestions as well ! Regards, Aaron
