On Thu, Jul 24, 2025 at 12:48:06 -0000, Aaron Brown wrote: > > On Tue, Jul 22, 2025 at 13:50:19 -0400, Aaron M. Brown wrote: > > > > One definition per line. > > > Okay I will remember that going forward! > > > > > This is suspicious because this function until now just returned the > > next eligible port, but now it's also reserving it which doesn't seem to > > fit well here. > > > > Can you please explain this? > > > Yes, I agree with you Peter, it is a bit unfitting, we can't process a port assigned to port 0 in virDomainVirtioSerialAddrReserve as it fails the virDomainVirtioSerialAddrIsComplete check, because that check makes sure that `info->addr.vioserial.port != 0` so such a port would show as imcomplete. > > And if we skip over reserving this port, that means the bitmap would show a clear bit at the first position for every subsequent device on the controller So while I agree that it needs to work properly with the reservation code, with the way the code is structured I don't think we should hide something which reserves ports into code that is not expected to do that.
