Peter Krempa <pkrempa@xxxxxxxxxx> writes: > On Wed, May 21, 2025 at 09:46:10 +0200, Peter Krempa via Devel wrote: >> On Wed, May 21, 2025 at 08:37:09 +0200, Markus Armbruster via Devel wrote: >> > Argument @detach has always been ignored. Start the clock to get rid >> > of it. >> > >> > Cc: Peter Xu <peterx@xxxxxxxxxx> >> > Cc: Fabiano Rosas <farosas@xxxxxxx> >> > Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx> >> > --- >> > docs/about/deprecated.rst | 5 +++++ >> > qapi/migration.json | 18 +++++++++--------- >> > 2 files changed, 14 insertions(+), 9 deletions(-) >> > >> > diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst >> > index 9665bc6fcf..ef4ea84e69 100644 >> > --- a/docs/about/deprecated.rst >> > +++ b/docs/about/deprecated.rst >> > @@ -179,6 +179,11 @@ Use ``job-dismiss`` instead. >> > >> > Use ``job-finalize`` instead. >> > >> > +``migrate`` argument ``detach`` (since 10.1) >> > +'''''''''''''''''''''''''''''''''''''''''''' >> > + >> > +This argument has always been ignored. >> >> Huh; libvirt is actually always specifying it for some reason. >> >> I'll post patches shortly getting rid of it completely in libvirt > > Patch 2/2 of > > https://lists.libvirt.org/archives/list/devel@xxxxxxxxxxxxxxxxx/message/VPMPVPG5DSFORQODG4JGMZ2MTOJDQPPF/ > > addresses the above. I noticed that 'dump-guest-memory' does also have > 'detach' option but that one at least has effect, even when it's not > really useful (blocking monitor if not used). Another long-running task that should be a job... > On behalf of libvirt: > > Series: > > ACKed-by: Peter Krempa <pkrempa@xxxxxxxxxx> Thanks!
