Re: [PATCH 0/2] qemu: monitor: Fix handling of 'detach' for 'migrate' and 'dump-guest-memory' QMP commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/21/25 10:06, Peter Krempa via Devel wrote:
> QEMU is deprecating 'detach' argument of 'migrate' as it was never
> actually used. Drop it in libvirt as we always specify it.
> 
> The monitor handler of 'dump-guest-memory' allows controlling 'detach'
> but always passes true. Libvirt doesn't want to block the monitor so
> hardcode 'true' in the monitor code instead.
> 
> 
> Peter Krempa (2):
>   qemuMonitorDumpToFd: Drop 'detach' argument
>   qemuMonitorJSONMigrate: Drop 'detach' QMP option
> 
>  src/qemu/qemu_driver.c       | 2 +-
>  src/qemu/qemu_monitor.c      | 5 ++---
>  src/qemu/qemu_monitor.h      | 3 +--
>  src/qemu/qemu_monitor_json.c | 6 ++----
>  src/qemu/qemu_monitor_json.h | 3 +--
>  tests/qemumonitorjsontest.c  | 3 +--
>  6 files changed, 8 insertions(+), 14 deletions(-)
> 

Reviewed-by: Michal Privoznik <mprivozn@xxxxxxxxxx>

Michal



[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux