Re: [PATCH 2/3] docs: backup: Hint at proper selinux labelling of the FD-passed NBD socket

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On a Monday in 2025, Peter Krempa via Devel wrote:
From: Peter Krempa <pkrempa@xxxxxxxxxx>

In case selinux is used on the host the socket passed to qemu needs to
be properly labelled. Add a hint to the example code.

Signed-off-by: Peter Krempa <pkrempa@xxxxxxxxxx>
---
docs/formatbackup.rst | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/docs/formatbackup.rst b/docs/formatbackup.rst
index 155a45a22f..df6392e3bd 100644
--- a/docs/formatbackup.rst
+++ b/docs/formatbackup.rst
@@ -53,6 +53,10 @@ were supplied). The following child elements and attributes are supported:

     import socket
     import libvirt
+     import selinux
+
+     # Optionally setup selinux context for the socket if the distro uses it
+     # selinux.setsockcreatecon_raw("system_u:object_r:svirt_t:s0")

Should this hint that the category should also match the domain, to be
"properly" labelled?

Either way:

Reviewed-by: Ján Tomko <jtomko@xxxxxxxxxx>

Jano


     s = socket.socket(socket.AF_UNIX, socket.SOCK_STREAM)
     s.bind("/path/to/socket")
--
2.49.0

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Virt Tools]     [Libvirt Users]     [Lib OS Info]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Big List of Linux Books]     [Yosemite News]     [KDE Users]     [Fedora Tools]

  Powered by Linux