Users do not care which blocks are set offline, when using size option
Consistently printing warnings/errors in this case may confuse them and
create the false impression that the enable/disable operation itself has
failed.
If size option succeeds, chmem should not print errors/warnings.
Hence, revert commit
48675a744 ("chmem: print warnings about failures always (not only with --verbose)")
---
sys-utils/chmem.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sys-utils/chmem.c b/sys-utils/chmem.c
index 52e6f49b3..bee2a90f8 100644
--- a/sys-utils/chmem.c
+++ b/sys-utils/chmem.c
@@ -146,12 +146,12 @@ static int chmem_size(struct chmem_desc *desc, int enable, int zone_id)
idxtostr(desc, index, str, sizeof(str));
rc = ul_path_writef_string(desc->sysmem, onoff, "%s/state", name);
- if (rc != 0) {
+ if (rc != 0 && desc->verbose) {
if (enable)
- warn(_("%s enable failed"), str);
+ fprintf(stdout, _("%s enable failed\n"), str);
else
- warn(_("%s disable failed"), str);
- } else if (desc->verbose) {
+ fprintf(stdout, _("%s disable failed\n"), str);
+ } else if (rc == 0 && desc->verbose) {
if (enable)
fprintf(stdout, _("%s enabled\n"), str);
else
--
2.50.1
