[PATCH 1/4] chrt: produce better error message for missing priority with implied -r

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Since commit 4c425142844d, the following two equivalent commands produce
different error messages:

  # chrt -r ls NEWS
  chrt: invalid priority argument: 'ls'
  # chrt ls NEWS
  chrt: unsupported priority value for the policy: 0: see --max for valid range

The latter error message is enigmatic: where did the user specify '0'?

Before the mentioned commit, the second command would produce the same
error message as the first.  Restore that behavior.

CC: Madadi Vineeth Reddy <vineethr@xxxxxxxxxxxxx>
Signed-off-by: Benno Schulenberg <bensberg@xxxxxxxxxx>
---
 schedutils/chrt.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/schedutils/chrt.c b/schedutils/chrt.c
index 1a9522728..e07284e41 100644
--- a/schedutils/chrt.c
+++ b/schedutils/chrt.c
@@ -524,6 +524,9 @@ int main(int argc, char **argv)
 		}
 	}
 
+	if (ctl->policy == SCHED_RR)
+		need_prio = true;
+
 	if (ctl->verbose)
 		show_sched_info(ctl);
 
-- 
2.48.2





[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux