On 7/14/2025 4:48 PM, Jeremy Linton wrote:
On 7/14/25 7:16 AM, Karel Zak wrote:
On Fri, Jul 11, 2025 at 02:16:48PM -0700, Paul Benoit wrote:
Remove the "Ampere-1a" part. On newer Ampere Computing systems, the
system/model name will be obtained from /sys/bus/soc/devices/soc0/
machine,
that is populated with the ARM SMC CC SOC_ID Name.
If I understand correctly, there are old systems without
/sys/.../soc0/machine, right? The change will remove Ampere-1a from
the lscpu output. This sounds backward incompatible.
Thats a good point, but as I understand it, Ampere hasn't been happy
with the string that is there.
Hi Jeremy and Karel,
While I haven't personally been part of those discussions, that's also
my understanding of the situation.
If its OK to break whatever scripts/etc might depend on it at the
moment, why not just update the string.
That's becoming even more tempting given the valid issues that you and
Karel have identified with my patch. Though, the nice thing about lscpu
picking up the Model name, from somewhere like
/sys/bus/soc/devices/soc0/, is that lscpu will be able to output the
model name of newly released processors without/before them needing to
be added to the lscpu part(s) table. That assumes a kernel where either
the ARM SMC CC SOC_ID (Name) handling code, or the support code for a
specific SOC, set the Model name from which /sys/bus/soc/devices/soc0/
gets set.
Then invert the check so that the /sys/bus entry is preferred?
That's the way I had originally coded things, but I was concerned about
the change in behavior of having the /sys/bus/soc/devices/soc0/ value
override the established part(s) table names for non-Ampere processors.