Hi Benno,
On 30/06/25 14:10, Benno Schulenberg wrote:
> The first argument is a priority not only for `chrt --pid <prio> <pid>`
> but also for `chrt <prio> <command> [<argument>...]`.
>
> This fixes an oversight in recent commit e7a2d62434.
>
> CC: Madadi Vineeth Reddy <vineethr@xxxxxxxxxxxxx>
> Signed-off-by: Benno Schulenberg <bensberg@xxxxxxxxxx>
> ---
> schedutils/chrt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/schedutils/chrt.c b/schedutils/chrt.c
> index 0bcdd1a1e..4c45eae80 100644
> --- a/schedutils/chrt.c
> +++ b/schedutils/chrt.c
> @@ -530,7 +530,7 @@ int main(int argc, char **argv)
>
> errno = 0;
>
> - if (need_prio || argc - optind == 2)
> + if (need_prio || argc - optind > 1)
> ctl->priority = strtos32_or_err(argv[optind], _("invalid priority argument"));
> else
> ctl->priority = 0;
LGTM.
Without this patch:
chrt 12 grep boo README
chrt: unsupported priority value for the policy: 0: see --max for valid range
With this patch:
chrt 12 grep boo README
See: http://vger.kernel.org/majordomo-info.html#taboo
Reviewed-by: Madadi Vineeth Reddy <vineethr@xxxxxxxxxxxxx>
Tested-by: Madadi Vineeth Reddy <vineethr@xxxxxxxxxxxxx>
Thanks,
Madadi Vineeth Reddy
