Re: [PATCH v2] chrt: Make priority optional for policies that don't use it

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 18/06/25 17:59, Benno Schulenberg wrote:
> 
> Op 18-06-2025 om 11:51 schreef Madadi Vineeth Reddy:
>> On 18/06/25 14:48, Karel Zak wrote:
>>> On Wed, Jun 18, 2025 at 10:18:29AM +0200, Benno Schulenberg
>>> wrote:
>>>> 
>>>> Get policy: chrt [options] -p <pid>
>>> 
>>> I really don't like the use of "-p." We should use "--pid"
>>> everywhere (in --help, man page, and examples).
>> 
>> I can spin off a separate patch to consistently use --pid instead
>> of -p in the help text, man page, and examples.
> 
> It should also drop the "[options]" part from the above:

Agreed.

> 
> Get policy: chrt --pid <pid>
> 
> As Karel says, specifying an option like --other or --fifo should
> always be understood as a modification request, not as an info
> request.

Yes, my only concern is ABI shouldn't break for existing users
who might be giving options and retrieving current settings.

So, my thought is just to make priority argument optional for
policies that don't use it and keep the existing behavior as is.

I can post another patch after this discussion that removes
"[options]" for querying current settings and the issues due
to changing existing behavior could be discussed there.

Thoughts?

Thanks,
Madadi Vineeth Reddy

> 
> 
> Benno
> 





[Index of Archives]     [Netdev]     [Ethernet Bridging]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]

  Powered by Linux