Re: [PATCH v4 1/1] md: add legacy_async_del_gendisk mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 18 Aug 2025 at 16:57, Yu Kuai <yukuai@xxxxxxxxxx> wrote:
>
> Hi,
>
> 在 2025/8/18 17:33, Luca Boccassi 写道:
> > On Thu, 14 Aug 2025 at 01:54, Yu Kuai <yukuai1@xxxxxxxxxxxxxxx> wrote:
> >>
> >> 在 2025/08/13 11:29, Xiao Ni 写道:
> >>> commit 9e59d609763f ("md: call del_gendisk in control path") changes the
> >>> async way to sync way of calling del_gendisk. But it breaks mdadm
> >>> --assemble command. The assemble command runs like this:
> >>> 1. create the array
> >>> 2. stop the array
> >>> 3. access the sysfs files after stopping
> >>>
> >>> The sync way calls del_gendisk in step 2, so all sysfs files are removed.
> >>> Now to avoid breaking mdadm assemble command, this patch adds the parameter
> >>> legacy_async_del_gendisk that can be used to choose which way. The default
> >>> is async way. In future, we plan to change default to sync way in kernel
> >>> 7.0. Then users need to upgrade to mdadm 4.5+ which removes step 2.
> >>>
> >>> Fixes: 9e59d609763f ("md: call del_gendisk in control path")
> >>> Reported-by: Mikulas Patocka <mpatocka@xxxxxxxxxx>
> >>> Closes: https://lore.kernel.org/linux-raid/CAMw=ZnQ=ET2St-+hnhsuq34rRPnebqcXqP1QqaHW5Bh4aaaZ4g@xxxxxxxxxxxxxx/T/#t
> >>> Suggested-and-reviewed-by: Yu Kuai <yukuai3@xxxxxxxxxx>
> >>> Signed-off-by: Xiao Ni <xni@xxxxxxxxxx>
> >>> ---
> >>> v2: minor changes on format and log content
> >>> v3: changes in commit message and log content
> >>> v4: choose to change to sync way as default first in commit message
> >>>    drivers/md/md.c | 56 ++++++++++++++++++++++++++++++++++++-------------
> >>>    1 file changed, 42 insertions(+), 14 deletions(-)
> >>>
> >> Aplied to md-6.17
> >> Thanks
> > Hi,
> >
> > I noticed this bugfix is not in 6.17~rc2 released yesterday, will it
> > be in rc3? Thanks
>
> Yes. You should see this in linux-next soon, and later in rc3.
>
> Thanks,
> Kuai

That's great, thank you





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux