On 8/28/25 15:57, Yu Kuai wrote: > From: Yu Kuai <yukuai3@xxxxxxxxxx> > > On the one hand unify bio split code, prepare to fix disordered split > IO; On the other hand fix missing blkcg_bio_issue_init() and > trace_block_split() for split IO. > > Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx> Looks OK to me. Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > diff --git a/drivers/md/raid1.h b/drivers/md/raid1.h > index d236ef179cfb..64548057583b 100644 > --- a/drivers/md/raid1.h > +++ b/drivers/md/raid1.h > @@ -178,7 +178,9 @@ enum r1bio_state { > * any write was successful. Otherwise we call when > * any write-behind write succeeds, otherwise we call > * with failure when last write completes (and all failed). > - * Record that bi_end_io was called with this flag... > + * > + * And for bio_split errors, record that bi_end_io was called with > + * this flag... Nit: s/.../. > */ > R1BIO_Returned, > /* If a write for this request means we can clear some -- Damien Le Moal Western Digital Research