Re: [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Yu Kuai <yukuai1@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 3 Sep 2025 06:26:36 -0700
Cc: hch@xxxxxxxxxxxxx, colyli@xxxxxxxxxx, hare@xxxxxxx, dlemoal@xxxxxxxxxx, tieren@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx, axboe@xxxxxxxxx, tj@xxxxxxxxxx, josef@xxxxxxxxxxxxxx, song@xxxxxxxxxx, kmo@xxxxxxxxxxxxx, satyat@xxxxxxxxxx, ebiggers@xxxxxxxxxx, neil@xxxxxxxxxx, akpm@xxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, cgroups@xxxxxxxxxxxxxxx, linux-raid@xxxxxxxxxxxxxxx, yukuai3@xxxxxxxxxx, yi.zhang@xxxxxxxxxx, yangerkun@xxxxxxxxxx, johnny.chenyi@xxxxxxxxxx
In-reply-to: <20250901033220.42982-5-yukuai1@huaweicloud.com>
References: <20250901033220.42982-1-yukuai1@huaweicloud.com> <20250901033220.42982-5-yukuai1@huaweicloud.com>

On Mon, Sep 01, 2025 at 11:32:09AM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
> 
> 1) trace_block_split() is missing and blktrace can't catch split events;
> 2) blkcg_bio_issue_init() is missing, and io-latency will not work
>    correctly for split bio.

Looks good:

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

References:
- [PATCH RFC v3 00/15] block: fix disordered IO in the case recursive split
  - From: Yu Kuai
- [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio
  - From: Yu Kuai

Prev by Date: Re: [PATCH RFC v3 14/15] block: fix disordered IO in the case recursive split
Next by Date: Re: [PATCH RFC v3 01/15] block: cleanup bio_issue
Previous by thread: [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio
Next by thread: Re: [PATCH RFC v3 04/15] blk-crypto: fix missing processing for split bio
Index(es):
- Date
- Thread

[Index of Archives] [Linux RAID Wiki] [ATA RAID] [Linux SCSI Target Infrastructure] [Linux Block] [Linux IDE] [Linux SCSI] [Linux Hams] [Device Mapper] [Device Mapper Cryptographics] [Kernel] [Linux Admin] [Linux Net] [GFS] [RPM] [git] [Yosemite Forum]