Dear Xiao,
Am 12.08.25 um 14:20 schrieb Xiao Ni:
On Tue, Aug 12, 2025 at 5:58 PM Paul Menzel <pmenzel@xxxxxxxxxxxxx> wrote:
[…]
Am 12.08.25 um 09:49 schrieb Xiao Ni:
commit 9e59d609763f ("md: call del_gendisk in control path") changes the
async way to sync way of calling del_gendisk. But it breaks mdadm
--assemble command. The assemble command runs like this:
1. create the array
2. stop the array
3. access the sysfs files after stopping
The sync way calls del_gendisk in step2, so all sysfs files are removed.
Now to avoid breaking mdadm assemble command, this patch adds a parameter
… the parameter legacy_async_del_gendisk …
ok
that can be used to choose which way. The default is async way. In future,
we can remove this parameter when users upgrade to mdadm 4.5 which removes
step2.
step 2
ok
Maybe say to first change the default, and then remove it.
I don't follow this. What's the meaning of "to first change the default"?
I mean, after, for example, the next LTS release, change the default of
the parameter to false, and then after another LTS release to remove the
parameter entirely. Or, seeing that the code is not that vast, leave the
parameter even longer. So, not remove the parameter, but first change
the default.
[…]
Kind regards,
Paul
