On Sat, May 24, 2025 at 02:13:09PM +0800, Yu Kuai wrote: > From: Yu Kuai <yukuai3@xxxxxxxxxx> > > Also move other values to md-bitmap.h and update comments. Hmm. The commit message looks very confusing to me. I think this should be two patches: 1) move defines relevant to the disk format from md-bitmap.c to md-bitmap.h 2) add new bits for llbitmap (and explain what they are). > +#define BITMAP_SB_SIZE 1024 And while we're at it: this is still duplicated in llbitmap.c later. But shouldn't it simply be replaced with a sizeof on struct bitmap_super_s? (and when cleaning thing up, rename that to bitmap_super without the _s and use it instead of the typedef at least for all new code)?
