On Sat, May 24, 2025 at 02:13:03PM +0800, Yu Kuai wrote: > + consistency_policy .. these doc changes look unrelated, or am I missing something? > -static void mddev_set_bitmap_ops(struct mddev *mddev, enum md_submodule_id id) > +static bool mddev_set_bitmap_ops(struct mddev *mddev) > { > xa_lock(&md_submodule); > - mddev->bitmap_ops = xa_load(&md_submodule, id); > + mddev->bitmap_ops = xa_load(&md_submodule, mddev->bitmap_id); > xa_unlock(&md_submodule); > - if (!mddev->bitmap_ops) > - pr_warn_once("md: can't find bitmap id %d\n", id); > + > + if (!mddev->bitmap_ops) { > + pr_warn_once("md: can't find bitmap id %d\n", mddev->bitmap_id); > + return false; > + } > + > + return true; This also looks unrelated and like another prep patch?