On 29/04/2025 02:43, Yu Kuai wrote:
accounting, IO done is more than IO start, and this is a bug.
for related bio-based disk driver, or blk-mq
for rq-based disk, it's better not to hide the BUG.
AFICS, this check was not present for mq, so is it really required
now? I suppose that the code is simpler to always have the check. I
find it an odd check to begin with...
This check do present for mq, for example, diskstats_show() and
update_io_ticks().
ok, I just noticed this in part_inflight_show() ->
blk_mq_in_flight_rw(), which didn't have such a check. I think that is
because we expect the tagset iter to provide a sane count value.
Thanks,
John
