Re: [PATCH RFC v2 02/14] md/md-bitmap: pass discard information to bitmap_{start, end}write

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>  	int (*startwrite)(struct mddev *mddev, sector_t offset,
> -			  unsigned long sectors);
> +			  unsigned long sectors, bool is_discard);
>  	void (*endwrite)(struct mddev *mddev, sector_t offset,
> -			 unsigned long sectors);
> +			 unsigned long sectors, bool is_discard);

a bool discard is not a very good interface.  I'd expect an op enum or a set
of flag to properly describe it.

But is start/end write really the right interface for discard or should it
have it's own set of ops?





[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux