On Thu, Mar 20, 2025 at 1:11 AM <mtkaczyk@xxxxxxxxxx> wrote: > > From: Mariusz Tkaczyk <mtkaczyk@xxxxxxxxxx> > > Sending on ML for wider audience. I would like to confirm that there > are no objections to remove klibc support. > > Kernel is exporting md_p.h and md_u.h which were newer used by mdadm. This > patchset integrates them with mdadm. There are some missing defines in kernel > headers, so they are redefined in ifndef blocks. > > md_p.h includes asm/byteorder.h and it provides endianess casting functions. > These functions are also provided by klibc. To fix this, I removed klibc > support because I determined that mdadm is not compiling with klibc > for at least 3 years. > > I also removed uclibc because it is not actively maintained, on other hand we > are working to enable musl: > https://github.com/md-raid-utilities/mdadm/issues/76 > > Thanks for review and feedback. > > CC: Xiao Ni <xni@xxxxxxxxxx> > CC: Nigel Croxon <ncroxon@xxxxxxxxxx> > CC: Song Liu <song@xxxxxxxxxx> > CC: Yu Kuai <yukuai@xxxxxxxxxx> > Link: https://github.com/md-raid-utilities/mdadm/pull/149 > > Mariusz Tkaczyk (3): > mdadm: Remove klibc and uclibc support > mdadm: include asm/byteorder.h > mdadm: use kernel raid headers > > Create.c | 2 - > Detail.c | 2 - > Examine.c | 2 - > Grow.c | 6 --- > Kill.c | 2 - > Makefile | 34 ++------------ > Manage.c | 2 - > Query.c | 2 - > README.md | 3 -- > mdadm.h | 108 +++++++------------------------------------- > mdmonitor.c | 2 - > super1.c | 126 ++-------------------------------------------------- > udev.c | 2 - > 13 files changed, 22 insertions(+), 271 deletions(-) > > -- > 2.43.0 > Hi Mariusz This patch set looks good to me. You need to re-submit the PR based on the latest version of https://github.com/md-raid-utilities/mdadm. So we can know if regression tests can run successfully. Acked-by: Xiao Ni <xni@xxxxxxxxxx>
