Search Postgresql Archives

Re: Latest patches break one of our unit-test, related to RLS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 2025-09-13 at 17:00 -0400, Tom Lane wrote:
> Laurenz Albe <laurenz.albe@xxxxxxxxxxx> writes:
> > I came up with the attached patch set.
> 
> I did some more work on the comments, adjusted a couple of places that
> could be simplified, and pushed it.

Thank you!

> > I used two separate patches for clarity and ease of review, but both
> > should get backpatched.
> 
> I didn't really love the "fix it and then explain it afterward"
> approach.  It's hard to review a patch if you don't understand the
> logic.  I considered swapping the order of the two patches, but
> eventually just merged them into one.

Yes, having the refactoring patch first might have been better.

Yours,
Laurenz Albe






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [Postgresql Jobs]     [Postgresql Admin]     [Postgresql Performance]     [Linux Clusters]     [PHP Home]     [PHP on Windows]     [Kernel Newbies]     [PHP Classes]     [PHP Databases]     [Postgresql & PHP]     [Yosemite]

  Powered by Linux