Re: Call for testing: OpenSSH 10.0

[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

 



Darren Tucker <dtucker@xxxxxxxxxxx> wrote:
> OpenSSH 10.0p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is primarily a bugfix
> release, although one notable change is the introduction of the sshd-auth
> binary (see below).

I noticed that bbc9c18e84 added a use of time() but didn't include
<time.h>:

	sshd.c: In function 'drop_connection':
	sshd.c:622:41: error: implicit declaration of function 'time' [-Wimplicit-function-declaration]
	  622 |         ratelimited = log_ratelimit(rl, time(NULL), NULL, &ndropped);
	      |                                         ^~~~
	sshd.c:96:1: note: 'time' is defined in header '<time.h>'; this is probably fixable by adding '#include <time.h>'
	   95 | #include "atomicio.h"
	  +++ |+#include <time.h>
	   96 |

This only appears with --without-openssl, so <time.h> must be getting
transitively included through openssl headers. It might also be
specific to musl, since musl's headers often don't pull in as much
stuff as other libcs.
_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev@xxxxxxxxxxx
https://lists.mindrot.org/mailman/listinfo/openssh-unix-dev



[Date Prev] [Date Next] [Thread Prev] [Thread Next] [Date Index] [Thread Index]

[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux