On 08.09.25 17:28, Lorenzo Stoakes wrote:
On Mon, Sep 08, 2025 at 05:03:54PM +0200, David Hildenbrand wrote:
On 08.09.25 13:10, Lorenzo Stoakes wrote:
The devdax driver does nothing special in its f_op->mmap hook, so
straightforwardly update it to use the mmap_prepare hook instead.
Signed-off-by: Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx>
---
drivers/dax/device.c | 32 +++++++++++++++++++++-----------
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/dax/device.c b/drivers/dax/device.c
index 2bb40a6060af..c2181439f925 100644
--- a/drivers/dax/device.c
+++ b/drivers/dax/device.c
@@ -13,8 +13,9 @@
#include "dax-private.h"
#include "bus.h"
-static int check_vma(struct dev_dax *dev_dax, struct vm_area_struct *vma,
- const char *func)
+static int __check_vma(struct dev_dax *dev_dax, vm_flags_t vm_flags,
+ unsigned long start, unsigned long end, struct file *file,
+ const char *func)
In general
Acked-by: David Hildenbrand <david@xxxxxxxxxx>
Thanks!
The only thing that bugs me is __check_vma() that does not check a vma.
Ah yeah, you're right.
Maybe something along the lines of
"check_vma_properties"
maybe check_vma_desc()?
Would also work, although it might imply that we are passing in a vma desc.
Well, you could let check_vma() construct a vma_desc and pass that to
check_vma_desc() ...
--
Cheers
David / dhildenb
