On Mon, 18 Aug 2025 20:25:02 +0200
Florian Westphal <fw@xxxxxxxxx> wrote:
> Stefano Brivio <sbrivio@xxxxxxxxxx> wrote:
> > > +static struct nft_pipapo_elem *pipapo_get(const struct nft_pipapo_match *m,
> > > + const u8 *data, u8 genmask,
> > > + u64 tstamp)
> > > +{
> > > + struct nft_pipapo_elem *e;
> > > +
> > > + local_bh_disable();
> > > +
> > > +#if defined(CONFIG_X86_64) && !defined(CONFIG_UML)
> > > + if (boot_cpu_has(X86_FEATURE_AVX2) && boot_cpu_has(X86_FEATURE_AVX) &&
> >
> > I don't have any straightforward idea on how to avoid introducing AVX2
> > stuff (even if compiled out) in the generic function, which we had
> > managed to avoid so far. I don't think it's a big deal, though.
>
> It could be hidden away in a static inline helper if that makes it more
> acceptable.
I think that would just make it... hidden. I'd rather leave it like it
is.
Reviewed-by: Stefano Brivio <sbrivio@xxxxxxxxxx>
--
Stefano
