On Tue, Aug 19, 2025 at 01:24:52AM +0200, Pablo Neira Ayuso wrote: > On Mon, Aug 18, 2025 at 11:07:34PM +0200, Phil Sutter wrote: > > On Mon, Aug 18, 2025 at 04:16:21PM +0200, Pablo Neira Ayuso wrote: > > > On Wed, Aug 13, 2025 at 07:05:35PM +0200, Phil Sutter wrote: > > > > This series consists of noise (patches 1-13 and most of patch 14) with a > > > > bit of signal in patch 14. This is because the relatively simple > > > > adjustment to JSON output requires minor adjustments to many stored JSON > > > > dumps in shell test suite and stored JSON output in py test suite. While > > > > doing this, I noticed some dups and stale entries in py test suite. To > > > > clean things up first, I ran tests/py/tools/test-sanitizer.sh, fixed the > > > > warnings and sorted the changes into fixes for the respective commits. > > > > > > Reviewed-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > > > > Series applied, thanks! > > > > > I will follow up with a patch to partially revert the fib check change > > > for JSON too. > > > > Hmm. That one seems like a sensible change and not just a simplification > > of output. > > Actually, I don't find an easy way to retain backward compatibility in > the JSON output for fib without reverting: > > commit 525b58568dca5ab9998595fc45313eac2764b6b1 > Author: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > Date: Tue Jun 24 18:11:10 2025 +0200 > > fib: allow to use it in set statements > > commit f4b646032acff4d743ad4f734aaca68e9264bdbb > Author: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> > Date: Tue Jun 24 18:11:06 2025 +0200 > > fib: allow to check if route exists in maps > > I am not sure I want to do that, because then the fib expression > cannot be used with sets/maps. I found a way, it is not "nice" but it helps to address the current issue: https://patchwork.ozlabs.org/project/netfilter-devel/patch/20250819092342.721798-1-pablo@xxxxxxxxxxxxx/
