On Tue, Aug 19, 2025 at 05:57:55PM +0200, Fernando Fernandez Mancera wrote: > > > On 8/19/25 2:47 PM, Pablo Neira Ayuso wrote: > > Hi, > > > > I made a changes to this series and push it out to the 'tunnel' branch > > under the nftables tree. > > > > I added IPv6 support to this 1/7 patch. > > > > However: > > > > [PATCH 6/7] tunnel: add tunnel object and statement json support > > > > still needs to be adjusted to also support IPv6. > > > > I can see JSON representation uses "src" and "dst" as keys. > > > > It is better to have keys that uniquely identify the datatype, I would > > suggest: > > > > "ip saddr" > > "ip6 saddr" > > > > (similar to ct expression) > > > > or > > > > "src-ipv4" > > "src-ipv6" > > > > Hi Pablo, > > I would prefer the latter options "src-ipv4" and "src-ipv6" mainly because > adding spaces to keys in a JSON should be avoided. > > I am sending a v3 with the requested changes, thank you! OK, thanks.