Re: [PATCH nft 1/2] evaluate: simplify set to list normalisation for device expressions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 21, 2025 at 11:17:40AM +0200, Pablo Neira Ayuso wrote:
> When evaluating the list of devices, two expressions are possible:
> 
> - EXPR_LIST, which is the expected expression type to store the list of
>   chain/flowtable devices.
> 
> - EXPR_SET, in case that a variable is used to express the device list.
>   This is because it is not possible to know if the variable defines
>   set elements or devices. Since sets are more common, EXPR_SET is used.
> 
> In the latter case, this list expressed as EXPR_SET gets translated to
> EXPR_LIST. Before such translation, the EXPR_VARIABLE is evaluated,
> therefore all variables are gone and only EXPR_SET_ELEM are possible in
> expr_set_to_list().
> 
> Remove the EXPR_VALUE and EXPR_VARIABLE cases in expr_set_to_list()
> since those are never seen. Add BUG() in case any other expressions than
> EXPR_SET_ELEM is seen.

Applied this series too.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux