On Tue, Sep 02, 2025 at 05:33:34PM +0200, Pablo Neira Ayuso wrote: > On Fri, Aug 29, 2025 at 05:51:59PM +0200, Phil Sutter wrote: > > Automake is supposed to set this for a full testrun. > > > > Signed-off-by: Phil Sutter <phil@xxxxxx> > > --- > > tests/py/nft-test.py | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/tests/py/nft-test.py b/tests/py/nft-test.py > > index 78f3fa9b27df7..52be394c1975a 100755 > > --- a/tests/py/nft-test.py > > +++ b/tests/py/nft-test.py > > @@ -1517,6 +1517,13 @@ def set_delete_elements(set_element, set_name, table, filename=None, > > signal.signal(signal.SIGINT, signal_handler) > > signal.signal(signal.SIGTERM, signal_handler) > > > > + try: > > + if os.environ["RUN_FULL_TESTSUITE"] != 0: > > + enable_json_option = True > > + enable_json_schema = True > > + except KeyError: > > + pass > > I would revisit options for tests to: > > 1) Run all tests by default, ie. native syntax and json. > 2) Add options to run native syntax (-pick-one-here) and json test only (-j). Ah, that's indeed a sensible measure - I did the same for iptables-test.py and the nice side-effect is that adding a new test-mode won't require education for callers, they just run it as well. > > Option 1) (default) will be fine for make check... and CI in general. > Option 2) will be only useful for development, for troubleshooting > broken tests. > > Then, add the env variable to shortcircuit tests with distcheck-hook: The interesting part is missing here. ;) I didn't find a better way to avoid test suite runs from 'make distcheck' while retaining 'make check'. Cheers, Phil
