Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote: > This patch normalizes the expression for mappings: > > EXPR_SET_ELEM -> EXPR_VALUE > / > EXPR_SET_ELEM -> EXPR_MAPPING | > \ > EXPR_VALUE Is the plan to eventually rewrite this to EXPR_VALUE / EXPR_SET_ELEM -> EXPR_MAPPING | \ EXPR_VALUE ? I don't see why there is a need to two set_elem shims. I makes sense to have all set elements that get stored be EXPR_SET_ELEM rather than a mix as we have now. But I don't understand double-set-elem for mapping. If its just an intermediate step, thats fine, no need for a huge series that rewrites everything.