Re: [nft PATCH 4/5] monitor: Inform JSON printer when reporting an object delete event

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Sep 08, 2025 at 12:30:05PM +0200, Pablo Neira Ayuso wrote:
> On Fri, Aug 29, 2025 at 04:25:12PM +0200, Phil Sutter wrote:
> > Since kernel commit a1050dd07168 ("netfilter: nf_tables: Reintroduce
> > shortened deletion notifications"), type-specific data is no longer
> > dumped when notifying for a deleted object. JSON output was not aware of
> > this and tried to print bogus data.
> 
> Fixes: e70354f53e9f ("libnftables: Implement JSON output support")

A Fixes: tag is fine with me, although one could argue that output was
fine before said kernel change. I'd rather refer to 9e88aae28e9f4
("monitor: Use libnftables JSON output") instead as this introduced the
relevant code in src/monitor.c.

> > Signed-off-by: Phil Sutter <phil@xxxxxx>
> 
> Reviewed-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Thanks, Phil




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux