Re: [nft PATCH v3 11/11] Makefile: Enable support for 'make check'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 11, 2025 at 02:02:37PM +0200, Phil Sutter wrote:
> Hi Pablo,
> 
> On Thu, Sep 04, 2025 at 08:39:40PM +0200, Phil Sutter wrote:
> > On Thu, Sep 04, 2025 at 06:57:52PM +0200, Pablo Neira Ayuso wrote:
> [...]
> > > distcheck-hook: could set a env var so test just print a [SKIP].
> > > 
> > > Similar to your previous approach with the env var, but logic reversed.
> > 
> > I don't think the 'make distcheck-hook' call is able to inject variables
> > into the following 'make check' call's environment. It could create a
> > special file though which all test suites recognize and exit 77
> > immediately.
> 
> What are your thoughts about this? IMO, the special configure option is
> much cleaner than creating a special file and patching all test runners
> to check for it.

Yes, makes sense, thanks.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux