On Sat, Sep 13, 2025 at 11:52 PM Florian Westphal <fw@xxxxxxxxx> wrote: > > Under what circumstances can flow->ct be NULL? I thought it could be NULL in a few cases. I’ll verify this on the inet/IPv4/IPv6 path and report back in the next spin. In any case, the null-guard is harmless, so I kept it. > This looks almost identical tcf_ct_flow_table_add_action_meta(). > > Any chance to make it a common helper function? act_ct already depends > on nf_flow_table anyway. agreed. If there are no objections to the main idea (exporting CT metadata on the nft flowtable path), I’ll prepare a new series that factors the fill logic into a shared helper and converts both act_ct and the nft exporter to use it Thanks for your feedback
