Re: [nft PATCH v3 0/3] evaluate: Fix for 'meta hour' ranges spanning date boundaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 31, 2025 at 01:19:01PM +0200, Pablo Neira Ayuso wrote:
> On Thu, Jul 31, 2025 at 12:25:33AM +0200, Phil Sutter wrote:
> > Kernel's timezone is UTC, so 'meta hour' returns seconds since UTC start
> > of day. To mach against this, user space has to convert the RHS value
> > given in local timezone into UTC. With ranges (e.g. 9:00-17:00),
> > depending on the local timezone, these may span midnight in UTC (e.g.
> > 23:00-7:00) and thus need to be converted into a proper range again
> > (e.g. 7:00-23:00, inverted). Since nftables commit 347039f64509e ("src:
> > add symbol range expression to further compact intervals"), this
> > conversion was broken.
> 
> Thanks for fixing my bugs.

Thanks for your review!

> Reviewed-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Patches applied.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux