Re: [PATCH v2 1/1] asn: fix missing quiet checks in xt_asn_build

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi. This is a trivial one line patch.  Can I please get it reviewed and merged or rejected with a reason?  Thanks


> On Jul 6, 2025, at 11:24 AM, Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> From: Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx>
> 
> Conceivably someone might want to run a refresh of the ASN database
> from within a script, particularly an unattended script such as a cron
> job. Do not generate summary output in that case.
> 
> Signed-off-by: Philip Prindeville <philipp@xxxxxxxxxxxxxxxxxxxxx>
> ---
> asn/xt_asn_build | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/asn/xt_asn_build b/asn/xt_asn_build
> index 63019ca689c56d5c9c686838fc4cc758047887e5..81c4965e572bbc7857a4832e0b80669104fe209f 100755
> --- a/asn/xt_asn_build
> +++ b/asn/xt_asn_build
> @@ -12,6 +12,7 @@ use Socket qw(AF_INET AF_INET6 inet_pton);
> use warnings;
> use Text::CSV_XS; # or trade for Text::CSV
> use strict;
> +$| = 1;
> 
> my $csv = Text::CSV_XS->new({
> allow_whitespace => 1,
> @@ -189,7 +190,7 @@ sub writeASN
> printf "%5u IPv%s ranges for %s\n",
> scalar(@ranges),
> ($family == AF_INET ? '4' : '6'),
> - $asn_number;
> + $asn_number unless ($quiet);
> 
> my $file = "$target_dir/".$asn_number.".iv".($family == AF_INET ? '4' : '6');
> if (!open($fh, '>', $file)) {
> -- 
> 2.43.0
> 






[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux