Re: [PATCH nft 0/4] detach concat, list and set expression layouts

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> wrote:
> These three expressions use the same layout but they have a different
> purpose, it is better to split them in independent layouts.

Agreed.

> This is implicitly reducing the size of one of the largest structs
> in the union area of struct expr, still EXPR_SET_ELEM remains the
> largest so no gain is achieved in this iteration.

Still, I'm all for reducing the number of anon structs in the union
and remove the SET/LIST/CONCAT joint struct.

Please, feel free to push this out.




[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux