在 2025/7/9 16:21, Jakub Sitnicki 写道:
On Wed, Jul 09, 2025 at 11:08 AM +08, Tao Chen wrote:
Use attach_type in bpf_link, and remove it in bpf_netns_link.
Acked-by: Jiri Olsa <jolsa@xxxxxxxxxx>
Signed-off-by: Tao Chen <chen.dylane@xxxxxxxxx>
---
kernel/bpf/net_namespace.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/kernel/bpf/net_namespace.c b/kernel/bpf/net_namespace.c
index 63702c86275..6d27bd97c95 100644
--- a/kernel/bpf/net_namespace.c
+++ b/kernel/bpf/net_namespace.c
@@ -11,7 +11,6 @@
struct bpf_netns_link {
struct bpf_link link;
- enum bpf_attach_type type;
enum netns_bpf_attach_type netns_type;
/* We don't hold a ref to net in order to auto-detach the link
Nit: Doesn't that create a hole? Maybe move netns_type to the end.
Hi Jakub,
You are right, i will change it in v4, thanks.
pahole -C bpf_netns_link vmlinux
struct bpf_netns_link {
struct bpf_link link __attribute__((__aligned__(8))); /*
0 80 */
/* XXX last struct has 7 bytes of padding */
/* --- cacheline 1 boundary (64 bytes) was 16 bytes ago --- */
enum netns_bpf_attach_type netns_type; /* 80 4 */
/* XXX 4 bytes hole, try to pack */
struct net * net; /* 88 8 */
struct list_head node; /* 96 16 */
/* size: 112, cachelines: 2, members: 4 */
/* sum members: 108, holes: 1, sum holes: 4 */
/* paddings: 1, sum paddings: 7 */
/* forced alignments: 1 */
/* last cacheline: 48 bytes */
} __attribute__((__aligned__(8)));
[...]
--
Best Regards
Tao Chen
