Re: [PATCH nft 3/3] src: only print the mss and wscale of synproxy if they are present

[Florian Westphal <fw@xxxxxxxxx>]

Zhongqiu Duan <dzq.aishenghu0@xxxxxxxxx> wrote:
> > > -     if (flags & (NF_SYNPROXY_OPT_MSS | NF_SYNPROXY_OPT_WSCALE))
> > > +     if ((flags & NF_SYNPROXY_OPT_MSS) && (flags & NF_SYNPROXY_OPT_WSCALE))
> > >               nft_print(octx, "synproxy mss %u wscale %u%s%s",
> > >                         stmt->synproxy.mss, stmt->synproxy.wscale,
> > >                         ts_str, sack_str);
> >
> > This looks wrong, this will now only print it if both are set.
> 
> The following else branch will handle the other conditions.

Urgh, indeed, orginal conditional makes no sense.