Re: [PATCH v2 3/4] test: shell: Add wait_local_port_listen() helper to lib.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thank you very much for your review and thoughtful guidance!

On Sun, Jun 22, 2025 at 10:18 PM Florian Westphal <fw@xxxxxxxxx> wrote:
>
> Yi Chen <yiche@xxxxxxxxxx> wrote:
> >  ip netns exec $S tcpdump -q --immediate-mode -Ui s_r -w ${PCAP} 2> /dev/null &
> >  pid=$!
> > +sleep 0.5
>
> You might want to add a wait_for_tcpdump_listen helper, that checks
> /proc/net/packet for tcpdump appearance, or /porc/$pid/fd/ for
> appearance of the packet socket.
>
> No need to resend and no need to work on this, just something to keep
> in mind of the future.
>
> I've applied all 4 patches and pushed them out, thanks for addressing
> all review comments.
>






[Index of Archives]     [Netfitler Users]     [Berkeley Packet Filter]     [LARTC]     [Bugtraq]     [Yosemite Forum]

  Powered by Linux