Yi Chen <yiche@xxxxxxxxxx> wrote: > 1. Add rate_limit test case. > 2. Consolidate frequently used functions in helper/lib.sh > 3. Introduce NFT_TEST_LIBRARY_FILE variable to source helper/lib.sh in > tests. > 4. Replace sleep with wait_local_port_listen(). > 5. Other fixes: nft->$NFT; add dumps/*.nodump files This is hard to review, can you split this in multiple patches to make it easier? We prefer to have one logical patch per change. For example: Patch1: don't use system nft binary You can also add the .nodump file in this patch. Patch 2: Consolidate frequently used functions in helper/lib.sh This also adds the NFT_TEST_LIBRARY_FILE environment variable and would switch nat_ftp and flowtables to use it. Patch 3: add and use wait_local_port_listen This would add the helper and convert sleeps after listener to use the new helper. Patch 4: Adds the new rate_limit test case and a nodump file. I mean, the changes look good to me but I think its too big for one single change.
