On Thu, Jun 12, 2025 at 01:29:50AM +0200, Pablo Neira Ayuso wrote:
> On Fri, Jun 06, 2025 at 12:41:49PM +0200, Florian Westphal wrote:
> > Bogon provides a handle but not a name.
>
> No handle for delete map command:
>
> | SET set_or_id_spec
> {
> $$ = cmd_alloc(CMD_DELETE, CMD_OBJ_SET, &$2, &@$, NULL);
> }
> | MAP set_spec
> ^^^^^^^^
>
> This is incomplete:
>
> f4a34d25f6d5 ("src: list set handle and delete set via set handle")
>
> but this is also lacking handle support:
>
> 745e51d0b8f0 ("evaluate: remove set from cache on delete set command")
>
> Then, reset command parser looks consistent:
>
> 83e0f4402fb7 ("Implement 'reset {set,map,element}' commands")
>
> but cmd_evaluate_reset() calls cmd_evaluate_list() which cannot deal
> with the handle.
>
> Looking at delete command for other objects, same issue, eg.
> chain_del_cache() also does not deal with this handle.
>
> I think the way to go is to add another hashtable to look up for
> object handles, I can post a patch for this purpose.
I started extending userspace to improve support for handles but it
turns out that kernel is missing a few bits for lookup by handle in
get/reset commands.
So I am only fixing this in a series by now.
